Skip to content

Lock click to older version #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Lock click to older version #200

wants to merge 2 commits into from

Conversation

sjmonson
Copy link
Collaborator

The latest version of click has dropped support for python 3.9 and has additionally introduced breaking interface changes. Until we drop python 3.9, lock to the last supported click version. Additionally types-click has been deprecated since click 8.0.0 so remove it.

@sjmonson sjmonson requested a review from markurtz June 25, 2025 16:12

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15881569980/artifacts/3403027462.
They will be retained for up to 30 days.

@sjmonson sjmonson self-assigned this Jun 27, 2025
@sjmonson sjmonson requested a review from jaredoconnell June 27, 2025 20:43

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/15935756417/artifacts/3422364854.
They will be retained for up to 30 days.

Copy link
Collaborator

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we need to get the CI to pass. Is the error present in main, or is the version change causing a new error, is is it exposing one that wasn't there before?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants